fix: always return the same value when resolving requests multiple times #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't warn if the user does something like:
fetchr.read('foo', { id: 42 });
We were doing it since internally we were calling end with an
undefined callback.
- Fetchr({}) => Fetchr()
- .read('foo', null) => .read('foo')
Before this commit, when calling fetchr on the client using the promise API and resolving it multiple times would lead to undefined values. We now make sure to always return the fetch promise in httpRequest. But doing so, broke the abort behavior since we would not return an FetchrHttpRequest to the user from fetchr methods. To fix that, we now save an instance of FetchrHttpRequest in the Request class and added an abort method to the later one to call FetchrHttpRequest.abort method.
redonkulus
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
I found a bug in our system when resolving a request multiple times. The first time it was resolved it was fine (and so fetchr tests), but at the second time it would resolve with an undefined value. The code was looking something like this:
Fixing it was simple, we just had to keep a reference to the fetch promise in
httpRequestand always return_request.theninFetchrHttpRequest.thenmethod.However, that broke the abort support since we were not returning an instance of
FetchrHttpRequestanymore to the caller. To solve that, it was also necessary to store a reference toFetchrHttpRequestin theRequestclass infetchr.client.js.I added a bunch of more tests to cover this and other cases as well.